Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add schemas for rules and tags #1335

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Conversation

nayeemrmn
Copy link
Contributor

@nayeemrmn nayeemrmn commented Oct 22, 2024

Towards denoland/deno#26314.

We will link to these at https://github.com/denoland/deno/blob/v2.0.2/cli/schemas/config-file.v1.json#L289-L317 using "$ref": "https://raw.githubusercontent.com/...". Similar to how the extension links to this file in the first place.

I included the two rules implemented in CLI in the schema.

If there's some automated CI checks we should do for these files, please advise.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can generate this file in similar fashion that documentation site is generated. Take a look at update-docs task - preferably just update that task to take care of generating schema file.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@nayeemrmn nayeemrmn merged commit 811b397 into denoland:main Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants